Re: [PATCH bpf-next v2] bpf: Simplify tnum_step()

From: Harishankar Vishwanathan

Date: Tue Mar 24 2026 - 17:33:52 EST


On Tue, Mar 24, 2026 at 11:50 AM <patchwork-bot+netdevbpf@xxxxxxxxxx> wrote:
>
> Hello:
>
> This patch was applied to bpf/bpf-next.git (master)
> by Alexei Starovoitov <ast@xxxxxxxxxx>:

Hello, I see this was applied. Just a heads up that I still had a few
concerns regarding the
commit message and code style in my last reply. I think it was my
mistake to include
the Reviewed-by while still requesting changes.

Hao, would you like to send a follow-up for those, or should I put one together?

Or Alexei, do you think it is okay as is? If yes, we can just leave it be.


> On Fri, 20 Mar 2026 17:23:36 +0100 you wrote:
> > Simplify tnum_step() from a 10-variable algorithm into a straight
> > line sequence of bitwise operations.
> >
> > Problem Reduction:
> >
> > tnum_step(): Given a tnum `(tval, tmask)` where `tval & tmask == 0`,
> > and a value `z` with `tval ≤ z < (tval | tmask)`, find the smallest
> > `r > z`, a tnum-satisfying value, i.e., `r & ~tmask == tval`.
> >
> > [...]
>
> Here is the summary with links:
> - [bpf-next,v2] bpf: Simplify tnum_step()
> https://git.kernel.org/bpf/bpf-next/c/833ef4a954e1
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
>