Re: [PATCH 4/6] riscv: dts: spacemit: enable QSPI and add SPI NOR on Milk-V Jupiter
From: Yixun Lan
Date: Tue Mar 24 2026 - 18:12:53 EST
Hi Aurelien,
On 22:19 Tue 24 Mar , Aurelien Jarno wrote:
> Hi Yixun,
>
> On 2026-03-24 17:02, Yixun Lan wrote:
> > Hi Aurelien,
..
> > ..
> > > Also add the bootph-pre-ram property to make the device tree usable by
> > > early firmware/bootloaders without modification, as U-Boot is stored on
> > > this NOR flash.
> > Is the dtb file actually used by U-Boot? I'd highly doubt about this,
> > if not the case or has not been tested, I'd suggest then not to add
> > this property..
>
> It is currently not used by U-Boot, currently SPL support is not
> available, but patches have been posted to added it. I just wanted to
> anticipate the addition of the Milk-V Jupiter board in U-boot, but if
> that hurt, i can remove it (or you can removed it when merging).
Not hurt since it isn't really used in Kernel, but I just don't
want to add things without test..
I can remove it if there is no other changes, then no iteration needed.
Let's wait a few more days to see if people have additional comments for
this series
--
Yixun Lan (dlan)