Re: [PATCH] lib: Split codetag_lock_module_list()

From: Andrew Morton

Date: Tue Mar 24 2026 - 18:16:59 EST


On Tue, 24 Mar 2026 14:42:25 -0700 Bart Van Assche <bvanassche@xxxxxxx> wrote:

> Letting a function argument indicate whether a lock or unlock operation
> should be performed is incompatible with compile-time analysis of
> locking operations by sparse and Clang.

And it makes Linus mad.

> Hence, split
> codetag_lock_module_list() into two functions: a function that locks
> cttype->mod_lock and another function that unlocks cttype->mod_lock. No
> functionality has been changed. See also commit 916cc5167cc6 ("lib: code
> tagging framework").

Thanks. I'd prefer to park this for the next cycle. The amount of
material I'm sitting on is excessive and I'm trying to give
reviews&testers time to catch up.