Re: [PATCH] arm64: dts: imx8mp: Add DT overlays for DH i.MX8M Plus DHCOM SoM and boards
From: Marek Vasut
Date: Tue Mar 24 2026 - 19:12:33 EST
On 3/24/26 9:00 PM, Frank Li wrote:
On Tue, Mar 24, 2026 at 06:39:10PM +0100, Marek Vasut wrote:
On 3/24/26 5:01 PM, Frank Li wrote:
On Fri, Mar 13, 2026 at 12:24:04AM +0100, Marek Vasut wrote:
...
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi
new file mode 100644
index 0000000000000..534737363c9f0
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-overlay-panel-ch101olhlwh.dtsi
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2022 Marek Vasut
2026?
That was the original copyright year when this was implemented, but I can
update it to 2022-2026 ?
Okay, you upstream this year.
Right, V2 does extend the copyrights until this year.
Maybe "make dtbs_check" target could include this tool , to make people aware of it ?+ */
+
+&display_bl {
+ pwms = <&pwm1 0 5000000 0>;
+};
+
+&DH_OVERLAY_PANEL_I2C_BUS {
why upcase for label, generally it should be lower case
Because this label is really a macro , please read on.
What is "dt-format" ? Linux kernel source tree, even current next, does not+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ touchscreen@41 {
+ compatible = "ilitek,ili251x";
+ pinctrl-0 = <DH_OVERLAY_PANEL_I2C_TOUCHSCREEN_PINCTRL>;
+ pinctrl-names = "default";
+ reg = <0x41>;
reg should second property, please dt-format for new dts files.
check others
mention such a tool . I did run schema check and checkpatch on these
patches. obv.
I send out at many place, https://github.com/lznuaa/dt-format
I write small tools to detect and fix node and property order problem,
it may be buggy.
These node order problem is easy to detected and fix by tools to save
review cycle and focus on the important stuff.