Re: [PATCH v2 3/3] net: pse-pd: add LED trigger support via notification path
From: kernel test robot
Date: Wed Mar 25 2026 - 00:40:44 EST
Hi Carlo,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on net-next/main net/main linus/master v7.0-rc5 next-20260324]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Carlo-Szelinsky/dt-bindings-net-pse-pd-add-poll-interval-ms-property/20260325-040935
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20260323201225.1836561-4-github%40szelinsky.de
patch subject: [PATCH v2 3/3] net: pse-pd: add LED trigger support via notification path
config: hexagon-randconfig-001-20260325 (https://download.01.org/0day-ci/archive/20260325/202603251254.o5PqMBRU-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260325/202603251254.o5PqMBRU-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603251254.o5PqMBRU-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/net/pse-pd/pse_core.c:1221:10: error: no member named 'pi_led_trigs' in 'struct pse_controller_dev'
1221 | pcdev->pi_led_trigs = NULL;
| ~~~~~ ^
1 error generated.
vim +1221 drivers/net/pse-pd/pse_core.c
1141
1142 /**
1143 * pse_controller_register - register a PSE controller device
1144 * @pcdev: a pointer to the initialized PSE controller device
1145 *
1146 * Return: 0 on success and failure value on error
1147 */
1148 int pse_controller_register(struct pse_controller_dev *pcdev)
1149 {
1150 size_t reg_name_len;
1151 int ret, i;
1152
1153 mutex_init(&pcdev->lock);
1154 INIT_LIST_HEAD(&pcdev->pse_control_head);
1155 spin_lock_init(&pcdev->ntf_fifo_lock);
1156 ret = kfifo_alloc(&pcdev->ntf_fifo, pcdev->nr_lines, GFP_KERNEL);
1157 if (ret) {
1158 dev_err(pcdev->dev, "failed to allocate kfifo notifications\n");
1159 return ret;
1160 }
1161 INIT_WORK(&pcdev->ntf_work, pse_send_ntf_worker);
1162
1163 if (!pcdev->nr_lines)
1164 pcdev->nr_lines = 1;
1165
1166 if (!pcdev->ops->pi_get_admin_state ||
1167 !pcdev->ops->pi_get_pw_status) {
1168 dev_err(pcdev->dev,
1169 "Mandatory status report callbacks are missing");
1170 return -EINVAL;
1171 }
1172
1173 ret = of_load_pse_pis(pcdev);
1174 if (ret)
1175 return ret;
1176
1177 if (pcdev->ops->setup_pi_matrix) {
1178 ret = pcdev->ops->setup_pi_matrix(pcdev);
1179 if (ret)
1180 return ret;
1181 }
1182
1183 /* Each regulator name len is pcdev dev name + 7 char +
1184 * int max digit number (10) + 1
1185 */
1186 reg_name_len = strlen(dev_name(pcdev->dev)) + 18;
1187
1188 /* Register PI regulators */
1189 for (i = 0; i < pcdev->nr_lines; i++) {
1190 char *reg_name;
1191
1192 /* Do not register regulator for PIs not described */
1193 if (!pcdev->no_of_pse_pi && !pcdev->pi[i].np)
1194 continue;
1195
1196 reg_name = devm_kzalloc(pcdev->dev, reg_name_len, GFP_KERNEL);
1197 if (!reg_name)
1198 return -ENOMEM;
1199
1200 snprintf(reg_name, reg_name_len, "pse-%s_pi%d",
1201 dev_name(pcdev->dev), i);
1202
1203 ret = devm_pse_pi_regulator_register(pcdev, reg_name, i);
1204 if (ret)
1205 return ret;
1206 }
1207
1208 ret = pse_register_pw_ds(pcdev);
1209 if (ret)
1210 return ret;
1211
1212 mutex_lock(&pse_list_mutex);
1213 list_add(&pcdev->list, &pse_controller_list);
1214 mutex_unlock(&pse_list_mutex);
1215
1216 ret = pse_led_triggers_register(pcdev);
1217 if (ret) {
1218 dev_warn(pcdev->dev, "Failed to register LED triggers: %d\n",
1219 ret);
1220 /* Ensure pse_led_update() is a no-op on partial failure */
> 1221 pcdev->pi_led_trigs = NULL;
1222 }
1223
1224 return 0;
1225 }
1226 EXPORT_SYMBOL_GPL(pse_controller_register);
1227
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki