RE: Re: [PATCH v2] ASoC: dt-bindings: imx-card: Add dsp_a DAI format

[Chancel Liu]

> > The imx-card machine driver originally supported only codecs operating
> > in i2s or dsp_b formats. This machine driver can support CS42448 codec
> > and this codec typically uses dsp_a for its TDM interface. Therefore,
> 
> And what about other formats, which was asked last time?
> 

The imx-card machine driver currently implements support only for
codecs with i2s and dsp_b format. The newly added CS42448 codec
requires dsp_a and that is why this patch adds dsp_a only. No other
formats are used or supported by the existing hardware covered by this
binding, so they are not included.

> > dsp_a format support is required for describing such sound cards in DT.
> >
> > Update DT bindings to include "dsp_a" in the list of supported DAI
> > formats.
> >
> > Signed-off-by: Chancel Liu <chancel.liu@xxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/sound/imx-audio-card.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Where is changelog?
> 

Sorry for this oversight.
I will add v2 change log(as well as for v3 and future versions)
for example:
changes in v2:
- Updated commit message to explain current support for i2s and dsp_b
formats and new support for dsp_a. No code changes.

> Where is any explanation how you handled or not handled previous review?
> 
> Best regards,
> Krzysztof

My intention in v2 was to directly fix the issues raised by you and
other reviewers and maintainers, but I mistakenly assumed that applying
the changes in the new version was sufficient. I understand now that it
is required to explicitly describe how each review comment was handled,
even if the changes are already included in the updated patch. I will
add a clear changelog and detailed explanation in v3.

Regards, 
Chancel Liu