Re: [PATCH v2] ASoC: Intel: boards: fix unmet dependency on PINCTRL

[Arnd Bergmann]

On Wed, Mar 25, 2026, at 01:15, Julian Braha wrote:
> This reverts commit c073f0757663 ("ASoC: Intel: sof_sdw: select 
> PINCTRL_CS42L43 and SPI_CS42L43")
>
> Currently, SND_SOC_INTEL_SOUNDWIRE_SOF_MACH selects PINCTRL_CS42L43
> without also selecting or depending on PINCTRL, despite PINCTRL_CS42L43
> depending on PINCTRL.
>
> See the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for PINCTRL_CS42L43
>   Depends on [n]: PINCTRL [=n] && MFD_CS42L43 [=m]
>   Selected by [m]:
>   - SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=m] && SOUND [=y] && SND [=m] && 
> SND_SOC [=m] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_SOF_INTEL_COMMON 
> [=m] || !SND_SOC_SOF_INTEL_COMMON [=m]) && SND_SOC_SOF_INTEL_SOUNDWIRE 
> [=m] && I2C [=y] && SPI_MASTER [=y] && ACPI [=y] && (MFD_INTEL_LPSS 
> [=n] || COMPILE_TEST [=y]) && (SND_SOC_INTEL_USER_FRIENDLY_LONG_NAMES 
> [=n] || COMPILE_TEST [=y]) && SOUNDWIRE [=m]
>
> In response to v1 of this patch [1], Arnd pointed out that there is
> no compile-time dependency sof_sdw and the PINCTRL_CS42L43 driver.
> After testing, I can confirm that the kernel compiled with
> SND_SOC_INTEL_SOUNDWIRE_SOF_MACH enabled and PINCTRL_CS42L43 disabled.
>
> This unmet dependency was detected by kconfirm, a static analysis
> tool for Kconfig.
>
> Link: 
> https://lore.kernel.org/all/b8aecc71-1fed-4f52-9f6c-263fbe56d493@xxxxxxxxxxxxxxxx/ 
> [1]
> Fixes: c073f0757663 ("ASoC: Intel: sof_sdw: select PINCTRL_CS42L43 and 
> SPI_CS42L43")
> Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>