Re: [PATCH v3 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series
From: Krzysztof Kozlowski
Date: Wed Mar 25 2026 - 04:47:51 EST
On Tue, Mar 24, 2026 at 08:21:07PM +0800, Zaixiang Xu wrote:
> Add YAML devicetree binding schema for Sensirion SHT30 series and
> GXCAS GXHT30 sensors. Wildcards are replaced with specific model
> names as per maintainer feedback.
Which wildcards? I do not see your patch replacing any wildcards. Your
patch only adds new code, so what "are replaced" means?
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@xxxxxxxxx/
What kernel test robot exactly report? That SHT30 is missing?
> Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@xxxxxxxxx>
> ---
> .../bindings/hwmon/sensirion,sht30.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> new file mode 100644
> index 000000000000..1b5ce822b37b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
> +$schema: http://devicetree.org/meta-schema.yaml#
> +
> +title: Sensirion SHT30 Humidity and Temperature Sensor
> +
> +maintainers:
> + - Zaixiang Xu <zaixiang.xu.dev@xxxxxxxxx>
> +
> +description: |
No improvements. More comments were also ignored.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof