Re: [PATCH net-next] sfc: add transmit timestamping support

[Breno Leitao]

On Tue, Mar 24, 2026 at 05:08:21PM +0100, Izabela Bakollari wrote:
> Enable software TX Timestamping. The out of tree driver 
> also implements this.

"The out of tree driver also implements this" is not the most technical
justification.

>
> Signed-off-by: Izabela Bakollari <ibakolla@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/sfc/ethtool.c | 2 ++
>  drivers/net/ethernet/sfc/tx.c      | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/ethtool.c b/drivers/net/ethernet/sfc/ethtool.c
> index 362388754a29..c0038b942913 100644
> --- a/drivers/net/ethernet/sfc/ethtool.c
> +++ b/drivers/net/ethernet/sfc/ethtool.c
> @@ -231,6 +231,8 @@ static int efx_ethtool_get_ts_info(struct net_device *net_dev,
>  {
>  	struct efx_nic *efx = efx_netdev_priv(net_dev);
>  
> +	ts_info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE;

Don't you need to append SOF_TIMESTAMPING_TX_SOFTWARE instead of
assinging it?

	ts_info->so_timestamping |= SOF_TIMESTAMPING_TX_SOFTWARE;