Re: [PATCH] drm/msm/dpu: correct DP MST interface configuration

[Konrad Dybcio]

On 3/25/26 10:57 AM, Konrad Dybcio wrote:
> On 3/25/26 6:32 AM, Dmitry Baryshkov wrote:
>> Due to historical reasons we ended up with dummy values being specified
>> for MST-related interfaces some of them had INTF_NONE, others had
>> non-existing DP controller indices. Those workarounds are no longer
>> necessary. Fix types and indices for all DP-MST related INTF instances.
>>
>> The only exception is INTF_3 on SC8180X, which has unique design. It can
>> be used either with INTF_0 / DP0 or with INTF_4 / DP1. This interface is
>> left with the dummy value until somebody implements necessary bits for
>> that platform.
>>
>> Co-developed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>> Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> ---
> 
>>  		.name = "intf_8", .id = INTF_8,
>>  		.base = 0x3c000, .len = 0x280,
>> -		.type = INTF_NONE,
>> -		.controller_id = MSM_DP_CONTROLLER_1,
>> +		.type = INTF_DP,
>> +		.controller_id = MSM_DP_CONTROLLER_1,	/* pair with intf_8 for DP MST */
> 
> with intf_4

Otherwise this is all correct

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Luca/Alexander, Milos will also have INTF0+INTF_3 paired

Konrad