Re: [PATCH] usb: xhci: Fix debugfs bandwidth reporting

[Michal Pecio]

On Thu, 19 Mar 2026 23:04:38 +0200, Mathias Nyman wrote:
> On 3/4/26 12:49, Michal Pecio wrote:
> > Replace kernel USB speed numbers with xHCI protocol IDs expected by HW.
> > They are numerically equal up to high speed, but instead of SuperSpeed
> > we were querying SuperSpeed+.
> > 
> > Gen1 hardware rejects such commands with TRB Error, which resulted in
> > zero available bandwidth being shown.
> > 
> > While at that, report command failure as IO error, not zero bandwidth.
> > 
> > Signed-off-by: Michal Pecio <michal.pecio@xxxxxxxxx>  
> 
> Added to queue

Hi,

Thanks for taking the patch, but can we have a last minute swap for
a v2 or optionally v3?

Problem is that returning -EIO is common (the command is optional)
and it upsets userspace: "grep -r" spams the console with errors,
"zip -R" terminates and doesn't include remaining files, etc.
So I would prefer to print an error string in this case.
"Real" errors will still be returned ordinarily.

The optional v3 also renames the new directory for consistency.
Technically it's a breaking change, but I believe it's permissible
in debugfs, particularly for an interface only added recently.

Regards,
Michal