Re: [PATCH v2 1/2] liveupdate: propagate file deserialization failures

[Pasha Tatashin]

On Wed, Mar 25, 2026 at 12:46 AM Leo Timmins <leotimmins1974@xxxxxxxxx> wrote:
>
> luo_session_deserialize() ignored the return value from
> luo_file_deserialize(). As a result, a session could be left partially
> restored even though the /dev/liveupdate open path treats deserialization
> failures as fatal.
>
> Propagate the error so a failed file deserialization aborts session
> deserialization instead of silently continuing.
>
> Fixes: 16cec0d26521 ("liveupdate: luo_session: add ioctls for file preservation")
>
> Signed-off-by: Leo Timmins <leotimmins1974@xxxxxxxxx>

Please preserve the tags.

Reviewed-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>

> ---
>  kernel/liveupdate/luo_session.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_session.c
> index 783677295640..25ae704d7787 100644
> --- a/kernel/liveupdate/luo_session.c
> +++ b/kernel/liveupdate/luo_session.c
> @@ -558,8 +558,13 @@ int luo_session_deserialize(void)
>                 }
>
>                 scoped_guard(mutex, &session->mutex) {
> -                       luo_file_deserialize(&session->file_set,
> -                                            &sh->ser[i].file_set_ser);
> +                       err = luo_file_deserialize(&session->file_set,
> +                                                  &sh->ser[i].file_set_ser);
> +               }
> +               if (err) {
> +                       pr_warn("Failed to deserialize files for session [%s] %pe\n",
> +                               session->name, ERR_PTR(err));
> +                       return err;
>                 }
>         }
>
> --
> 2.53.0
>