Re: [PATCH] dt-bindings: reset: st: convert to dtschema
From: Gopi Krishna Menon
Date: Wed Mar 25 2026 - 09:25:12 EST
On Wed, Mar 25, 2026 at 01:36:15PM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2026 13:04, Gopi Krishna Menon wrote:
> > On Wed, Mar 25, 2026 at 12:39:36PM +0100, Krzysztof Kozlowski wrote:
> >
> >> On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
> >>> Convert the STiH4xx reset controller bindings to DT schema.
> >>>
> >>> Suggested-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> >>> Suggested-by: Dhruva Gole <d-gole@xxxxxx>
> >>
> >> Both suggested you to write this patch?
> >>
> > Hi Krzysztof,
> >
> > Thanks for the review, They helped me to improve the PATCH,
> >
> > - Dhruva suggested me to change the subject from dt-bindings: power:
> > reset: st: convert to dtschema to dt-bindings: reset: st: convert to
> > dtschema as that was the general trend followed with similar files.
> > - Daniel suggested me to use the word 'reset' instead of 'restart' in
> > the patch (whereever possible) as that is more accurate here.
> >
> > That's why I added those Suggested-by tags.
>
> This is not the meaning of Suggested-by. Drop the tags.
>
Understood. Will remove it and send the v2.
> I gave you now review, so you will add "Suggested-by: Krzysztof ..."?
>
Earlier I would have. Didnt understand the use and meaning of this tag properly.
But will take care not to let this happen in future.
> Best regards,
> Krzysztof