Re: [PATCH] dt-bindings: i2c: intel,ixp4xx-i2c: Convert to Dt schema

[ShiHao]

On Wed, Mar 25, 2026 at 12:16:27PM +0100, Krzysztof Kozlowski wrote:

> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
> 

Hello Krzysztof, 

      Once again thank you for your time. Those warnings are from running
      checkpatch.pl without the --strict option i myself discovered when you
      said that because i only use it with --strict option. I thought
      checkpatch.pl --strict  was more strict then checkpatch.pl but i guess
      it is not so strict as i thought it was. But apart from this i mean
      why in the first place there is the --strict option when it is actually
      not so strict it must have shown all errors, checks and warnings but it
      does not Anyway i will make sure to run both from now on thanks for pointing
      it.

> > +properties:
> > +  compatible:
> > +    enum:
> > +      - intel,ixp4xx-i2c
> > +      - intel,iop3xx-i2c
> 
> Alphabetical order. Dunno why you reversed it from original binding.
> 
> 
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> 
> This wasn't in the original binding.
> 
> What does my guideline/expectations for GSoC say? Did you read it?
> 
> 

 I will make sure to fix these issues in the next version. Also
 i did not read any guidelines so, please provide some resources
 to the GSoC guidlines you mentioned. I texted on IRC but Daniel
 said email is where i should ask for it. Thanks for your time.

Kind regards
Shihao