Re: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings

[Shuah Khan]

On 3/25/26 01:22, Dan Carpenter wrote:
> There are a couple of different things happening here.  The mentorship
> program has its own rules.  The rule that people should test their code
> seems like a good rule.

Correct. The goal is to avoid introducing regressions.

> In staging, most of the patches that we apply not tested.  I assumed
> this patch wasn't tested.  Patches like this are not a big deal because
> we can easily review them.  Sometimes, patches change runtime so unless
> it's a security issue, we want those to be tested.
>
> > -	if (0x00 == PathAOK) {
> > -	}
>
> We normally wouldn't merge patches which do multiple things at once
> but it doesn't really make sense to reverse this condition around since
> it's dead code so to me it falls under the "related change" category.

My primary concern with this change is that it 10 files changed, with
26 insertions(+), 32 deletions(-)

It can be difficult to find any regressions unless the changes are
tested. I understand it is staging repo, but if we relax the rules
for staging irrespective of the scope of change, it becomes lot
harder to find regressions later. We are essentially leaving the
job of testing to users. Also if ans when the driver is pulled into
mainline, it will inherit the regressions that crept in.

thanks,
-- Shuah