Re: [PATCH 3/5] hwmon: (pmbus/core) Protect regulator operations with mutex

From: Guenter Roeck

Date: Wed Mar 25 2026 - 16:02:12 EST


Hi,

On 3/25/26 12:05, Pradhan, Sanman wrote:
From: Sanman Pradhan <psanman@xxxxxxxxxxx>

Reviewed the series.

Very minor hardening thought: the notifier worker is
initialized after the devm_regulator_register() loop.

The current probe ordering makes that fine, so I don't
think this is a bug, but would it be cleaner to initialize
the notifier state a bit earlier just to keep that
setup self-contained?


The interrupt handler is installed after registering the regulator,
so I don't think that is a problem since the regulator notifier
is called from the interrupt handler.

Don't see any blocking issues in the rest of the series.


Thanks a lot for the review and feedback. Surprisingly, Sashiko did not
find anything either:

https://sashiko.dev/#/patchset/20260325181631.17259-1-linux%40roeck-us.net

If you don't mind, please send me a formal Reviewed-by: tag for the series
or for individual patches.

Thanks,
Guenter