Re: [PATCH v8 02/31] gpu: nova-core: factor .fwsignature* selection into a new find_gsp_sigs_section()

[John Hubbard]

On 3/25/26 3:45 AM, Alexandre Courbot wrote:
> On Tue, 24 Mar 2026 20:52:13 -0700, John Hubbard <jhubbard@xxxxxxxxxx> wrote:
>> diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/firmware/gsp.rs
>> index c1f0a606f5c0..8bbc3809c640 100644
>> --- a/drivers/gpu/nova-core/firmware/gsp.rs
>> +++ b/drivers/gpu/nova-core/firmware/gsp.rs
>> @@ -146,6 +146,24 @@ pub(crate) struct GspFirmware {
>> [ ... skip 14 lines ... ]
>> +            Architecture::Blackwell if matches!(chipset, Chipset::GB100 | Chipset::GB102) => {
>> +                Some(".fwsignature_gb10x")
>> +            }
>> +            Architecture::Blackwell => Some(".fwsignature_gb20x"),
>> +        }
>> +    }
> 
> The match statement is exhaustive and we never return `None` here, so
> there is no need to return an `Option`.
> 

Right, and also true even after splitting Blackwell into two arches.
(There has been a lot of churn in this Arch/chipset area, and clippy
doesn't really cover this, so it's one of those things that an
actual review really helps find.)

Fixed for v9.

thanks,
-- 
John Hubbard