Re: [PATCH v4 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[Guenter Roeck]

On 3/25/26 11:20, Conor Dooley wrote:
> On Wed, Mar 25, 2026 at 05:08:08PM +0800, Zaixiang Xu wrote:
> > Add YAML devicetree binding schema for Sensirion SHT30 series.
> > Use fallback compatibles for compatible chips and add optional
> > interrupts and vdd-supply properties.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/r/202603212044.BRPaiz86-lkp@xxxxxxxxx/
>
> The robot did not report that this binding was missing.
> It also told you not to add these tags.
>
> You also ignored my and Krzysztof's reviews.
>
> NAK.

Maybe we should just point to AI feedback:

https://sashiko.dev/#/patchset/1774429690-129139-1-git-send-email-zaixiang.xu.dev%40gmail.com

and only get involved after AI does not report any problems.

Guenter

> pw-bot: changes-requested
>
> > Signed-off-by: Zaixiang Xu <zaixiang.xu.dev@xxxxxxxxx>
> > ---
> >   .../bindings/hwmon/sensirion,sht30.yaml       | 50 +++++++++++++++++++
> >   1 file changed, 50 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> > new file mode 100644
> > index 000000000000..1b5ce822b37b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/sensirion,sht30.yaml#
> > +$schema: http://devicetree.org/meta-schema.yaml#
> > +
> > +title: Sensirion SHT30 Humidity and Temperature Sensor
> > +
> > +maintainers:
> > +  - Zaixiang Xu <zaixiang.xu.dev@xxxxxxxxx>
> > +
> > +description: |
> > +  The SHT30 series is a family of humidity and temperature sensors by Sensirion.
> > +  Compatible sensors like the GXCAS GXHT30 are also supported.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - gxcas,gxht30
> > +      - sensirion,sht30
> > +      - sensirion,sht31
> > +      - sensirion,sht35
> > +      - sensirion,sht85
> > +      - sensirion,sts30
> > +      - sensirion,sts31
> > +      - sensirion,sts32
> > +      - sensirion,sts35
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description: I2C address (usually 0x44 or 0x45)
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        sensor@44 {
> > +            compatible = "gxcas,gxht30";
> > +            reg = <0x44>;
> > +        };
> > +    };
> > +
> > --
> > 2.34.1