Re: [PATCH v8 04/31] gpu: nova-core: add Copy/Clone to Spec and Revision, add chipset() accessor

[John Hubbard]

On 3/25/26 3:47 AM, Alexandre Courbot wrote:
> On Tue, 24 Mar 2026 20:52:15 -0700, John Hubbard <jhubbard@xxxxxxxxxx> wrote:
>> diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs
>> index 3b4ccc3d18b9..3cd7709883be 100644
>> --- a/drivers/gpu/nova-core/gpu.rs
>> +++ b/drivers/gpu/nova-core/gpu.rs
>> @@ -291,10 +298,9 @@ pub(crate) fn new<'a>(
>>      ) -> impl PinInit<Self, Error> + 'a {
>>          try_pin_init!(Self {
>>              spec: Spec::new(pdev.as_ref(), bar).inspect(|spec| {
>> -                dev_info!(pdev,"NVIDIA ({})\n", spec);
>> +                dev_info!(pdev, "NVIDIA ({})\n", spec);
> 
> This doesn't belong to this patch - let's apply this when we actually
> touch this part of the code. The next patch removes this line, so that's
> the right place to fix formatting.
> 
>>              })?,
>>  
>> -            // We must wait for GFW_BOOT completion before doing any significant setup on the GPU.
> 
> Same here, why remove this in this patch?
> 

Fixed both, thanks.

thanks,
-- 
John Hubbard