Re: [PATCH v6 5/5] arm64: dts: qcom: hamoa-iot-evk: Add Embedded controller node

[Anvesh Jain P]

On 3/25/2026 5:50 PM, Gaurav Kohli wrote:
> 
> 
> On 3/25/2026 5:09 PM, Anvesh Jain P wrote:
>> From: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
>>
>> Add embedded controller node for Hamoa IOT EVK boards which adds fan
>> control, temperature sensors, access to EC internal state changes and
>> suspend entry/exit notifications to the EC.
>>
>> Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>> Co-developed-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
>> ---
>>   arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts b/arch/arm64/
>> boot/dts/qcom/hamoa-iot-evk.dts
>> index 460f27dcd6f6..a0d2ccf931ec 100644
>> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
>> @@ -831,6 +831,16 @@ eusb6_repeater: redriver@4f {
>>           pinctrl-0 = <&eusb6_reset_n>;
>>           pinctrl-names = "default";
>>       };
>> +
>> +    embedded-controller@76 {
>> +        compatible = "qcom,hamoa-iot-evk-ec", "qcom,hamoa-crd-ec";
>> +        reg = <0x76>;
>> +
>> +        interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
>> +
>> +        pinctrl-0 = <&ec_int_n_default>;
>> +        pinctrl-names = "default";
>> +    };
>>   };
>>   
> For Hamoa iot evk board, i have also tried and cooling nodes are
> reflecting fine.
> Please feel free to add:
> Reviewed-by: Gaurav Kohli <gaurav.kohli@xxxxxxxxxxxxxxxx>
> Tested-by: Gaurav Kohli <gaurav.kohli@xxxxxxxxxxxxxxxx>
>

Thanks for testing. Will add the tags in next re-spin.

-- 
Best Regards,
Anvesh