Re: [PATCH v6 0/4] Enable secondary USB controller in host mode

[Swati Agarwal]

On Mon, Mar 23, 2026 at 1:12 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 23/03/2026 08:36, Swati Agarwal wrote:
> > On Wed, Mar 18, 2026 at 12:33 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >>
> >> On Wed, Mar 18, 2026 at 09:36:40AM +0530, Swati Agarwal wrote:
> >>> Enable secondary USB controller in host mode.
> >>>
> >>> This patch depends on:
> >>> https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@xxxxxxxxxxxxxxxx/
> >>
> >> Honestly? No. Drivers cannot depend on DTS.
> > Hi Krysztof,
> >
> > Here what i meant by dependency is that I have rebase this patch
> > series over below patch series. Below patch series is related to USB2
>
> And you should not. Drivers cannot be based on DTS branch.
>
> > micro USB controller support on lemans EVK.
> > https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@xxxxxxxxxxxxxxxx/
> >
> > There is no dependency of drivers on DT.
> >
> >>
> >> Also, combining here USB is a no-go. Do not combine independent
> >> patchsets into one patchset.
> >>
> >> I also do not see how you addressed my comments from previous version.
> >> You never bothered to respond and I do not see them implemented.
> >
> > Apologies if i missed replying any comments.
> > Regarding your comment on v3 series below:- GL3590 hub used in lemans
> > EVK requires only 1.2V and 3.3V supplies for operation, confirmes the
> > same from our internal HW team and update the same in thereafter patch
> > sets.
> > https://lore.kernel.org/all/20251220-economic-gay-firefly-1873a9@quoll/
>
> This does not address the feedback. I did not talk about Lemans EVK. I
> don't even have its datasheet. We speak here about GL3590. I found at
> least three supplies in datasheet. Your binding has only two.

Hi Krysztof,
For HUB GL3590, there are three supplies which are VP10, VP33 and
VP12. I have already used VP12 and VP33 in bindings. VP10 i have not
mentioned since its internal supply and other two are external
supplies to hub. VP10 is internal regulator and its pins just loop
back. Regarding AVDD10 and AVDD33, so AVDD10 is internal power hub
which is routed to several pins for different functions such as the
PLL and AVDD33 is external power hub where the external 3.3V gets
connected for multiple devices.

Regards,
Swati