Re: [PATCH 1/2] dt-bindings: i2c: spacemit: k3: Add compatible

From: Javier Martinez Canillas

Date: Thu Mar 26 2026 - 03:47:33 EST


Conor Dooley <conor@xxxxxxxxxx> writes:

Hello Conor,

> On Wed, Mar 25, 2026 at 02:20:13PM +0100, Javier Martinez Canillas wrote:
>> Yixun Lan <dlan@xxxxxxxxxx> writes:
>>
>> > Add a compatible string for the I2C controller found in SpacemiT K3 SoC
>> > which use same I2C IP as K1, so make it fallback to K1 compatible.
>> >
>>
>> If is the same IP as K1, shouldn't the "spacemit,k1-i2c" compatible be
>> used in the k3.dtsi instead? My understanding is that this is the meaning
>> of compatible, and there's no need to add another compatible string for k3.
>
> Your understanding is incorrect! What Yixun has done here is what we
> want people to do, because even if the IP is the same there can be
> differences due to integration that are problematic. Having a device
> specific compatible allows us to handle these kinds of problems if they
> crop up in the future.

Thanks for the clarification! It seems the convention changed over the
years then.

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat