Re: [PATCH v2 0/4] Add support for LTC2305
From: Jonathan Cameron
Date: Thu Mar 26 2026 - 04:22:22 EST
On Thu, 26 Mar 2026 02:21:28 +0000
"Jones, Carlos jr" <Carlosjr.Jones@xxxxxxxxxx> wrote:
> > On Tue, 24 Mar 2026 15:13:27 +0800
> > Carlos Jones Jr <carlosjr.jones@xxxxxxxxxx> wrote:
> >
> > > The LTC2305 is a 2-channel, 12-bit, fast ADC with an I2C interface,
> > > compatible with the LTC2309 (which has 8 channels).
> > >
> > > This patch adds support for the LTC2305 by introducing a chip_info
> > > structure to handle the different channel configurations between the
> > > two variants. The LTC2305 exposes 2 single-ended channels and 2
> > > differential combinations.
> > >
> > > Also updates the device tree bindings to include the lltc,ltc2305
> > > compatible string and documents it in the Kconfig.
> > > ---
> >
> > Whilst checking for what comments were in v1, I realized we have two
> > different people looking at the same thing within a few weeks of each other.
> > +cc Kyle.
> >
> > https://urldefense.com/v3/__https://lore.kernel.org/all/20260325-
> > add_ltc2305_driver-v5-0-
> > e0d29daa54f9@xxxxxxxxx/*r__;Iw!!A3Ni8CS0y2Y!6jxk_dJQLHUO4PVi3Oca_
> > VzVHN-qeFu-y2tE5xXMwuy-
> > x2UFG5Fn3KO4Cw15QcDsqTCgFXQQLLRQrdgokg$
> >
> > I guess this is just a case of neither noticing on the list?
> > Too many similar part names, so I missed it until now.
> >
> > Currently I have Kyle's patches queued up. All else being equal that seems fair
> > as Kyle started on this last year whereas Carlos' work on this is much more
> > recent.
> >
> > I'm seeing some small differences. Please could you work together on this.
> > Ideally send any additional changes on top of Kyle's series.
> >
> > Thanks,
> >
> > Jonathan
> >
>
> First off, my apologies to everyone for not knowing how to check for
> existing upstream request for the LTC2305 device before working on it
> and wasting everyone's review time. It's a learning experience for me.
It is pretty rare! Only tend to see this sort of collision once every
few years.
>
> But it's still awesome to see how both ended up with almost the same
> code after review.
>
> I'll reply to Kyle's series to ask if the delay for LTC2305 could be included.
Excellent! Note I've merged Kyle's code, so patches on top please.
Potentially the delay might be a fix if I understand it correctly.
Thanks,
Jonathan
>
> Kind regards,
> Carlos
>