Re: [PATCH net-next v4] selftests: net: add tests for PPP
From: Sebastian Andrzej Siewior
Date: Thu Mar 26 2026 - 04:30:29 EST
On 2026-03-26 16:26:23 [+0800], Qingfang Deng wrote:
> Hi Sebastian,
Hi Qingfang,
> On Thu, Mar 26, 2026 at 4:13 PM Sebastian Andrzej Siewior
> <bigeasy@xxxxxxxxxxxxx> wrote:
> >
> > On 2026-03-26 10:16:24 [+0800], Qingfang Deng wrote:
> > > Add ping and iperf3 tests for ppp_async.c and pppoe.c.
> >
> > Oh thank you for doing this.
> > I haven't look in detail but this cover the "invalid loop" cases that
> > ppp tries to catch?
>
> By "invalid loop", do you mean transmit recursion?
> https://lore.kernel.org/all/20250715150806.700536-2-bigeasy@xxxxxxxxxxxxx/
>
> AFAIK, this can only happen with PPTP or L2TP, which were not included
> in this patch.
Yeah, that one. I was sort of looking into but gave up after a while
digging through code, since I had no idea how to setup that up…
> Add Cc: Guillaume Nault
>
>
> Regards,
> Qingfang
Sebastian