Re: [PATCH] misc: ad525x_dpot: fix macro parentheses and permissions

From: Greg Kroah-Hartman

Date: Thu Mar 26 2026 - 05:08:06 EST


On Thu, Mar 26, 2026 at 04:55:10PM +0800, Haoyu Lu wrote:
> From: "haoyu.lu" <hechushiguitu666@xxxxxxxxx>
>
> Fix checkpatch.pl warnings:
> - Macros with complex values should be enclosed in parentheses
> - Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred
>
> Signed-off-by: haoyu.lu <hechushiguitu666@xxxxxxxxx>

Please do not do checkpatch cleanups in other areas of the kernel when
you do not have the experience of doing them first in drivers/staging/
as due to a number of problems in this patch, it obviously can not be
applied :(

thanks,

greg k-h