Re: [PATCH net-next v2 09/12] selftests: drv-net: Add MAC loopback netdevsim test

From: Breno Leitao

Date: Thu Mar 26 2026 - 05:42:18 EST


On Wed, Mar 25, 2026 at 03:50:16PM +0100, Björn Töpel wrote:

> +def _dfs_write_u32(cfg, path, val):
> + with open(os.path.join(_nsim_dfs_path(cfg), path), "w",
> + encoding="utf-8") as f:
> + f.write(str(val))

This function doesn't seem to be called, right?

> +def main() -> None:
> + """Run netdevsim loopback tests."""
> + with NetDrvEnv(__file__) as cfg:
> + cfg.ethnl = EthtoolFamily()

Given some functions above assume this is nsim, should you call
cfg.require_nsim() ?

Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>