Re: [PATCH v4 05/10] KVM: s390: Correctly handle guest mappings without struct page

[Christian Borntraeger]

Am 25.03.26 um 18:13 schrieb Claudio Imbrenda:
> Introduce a new special softbit for large pages, like already presend
> for normal pages, and use it to mark guest mappings that do not have
> struct pages.
>
> Whenever a leaf DAT entry becomes dirty, check the special softbit and
> only call SetPageDirty() if there is an actual struct page.
>
> Move the logic to mark pages dirty inside _gmap_ptep_xchg() and
> _gmap_crstep_xchg_atomic(), to avoid needlessly duplicating the code.



> Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
> Fixes: 5a74e3d93417 ("KVM: s390: KVM-specific bitfields and helper functions")
> Fixes: a2c17f9270cc ("KVM: s390: New gmap code")

Reviewed-by: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>

> ---
>   arch/s390/kvm/dat.h  | 12 ++++++------
>   arch/s390/kvm/gmap.c |  5 +----
>   arch/s390/kvm/gmap.h |  4 ++++
>   3 files changed, 11 insertions(+), 10 deletions(-)
[..]