RE: [PATCH v2 2/2] arm64: dts: renesas: rzg3l-smarc-som: Enable eth0 (GBETH0) interface

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 26 March 2026 09:30
> Subject: Re: [PATCH v2 2/2] arm64: dts: renesas: rzg3l-smarc-som: Enable eth0 (GBETH0) interface
> 
> Hi Biju,
> 
> On Tue, 3 Feb 2026 at 13:35, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Enable the Gigabit Ethernet Interfaces (GBETH0) populated on the
> > RZ/G3L SMARC EVK. The eth1, pincontrol definitions and hotplug support
> > will be added later.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg3l-smarc-som.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg3l-smarc-som.dtsi
> 
> >  &extal_clk {
> >         clock-frequency = <24000000>;
> >  };
> > +
> > +&mdio0 {
> > +       phy0: ethernet-phy@7 {
> > +               compatible = "ethernet-phy-id0022.1640",
> > +                            "ethernet-phy-ieee802.3-c22";
> 
> Drop the latter?

Agreed.

> 
> > +               reg = <7>;
> > +               rxc-skew-psec = <1400>;
> > +               txc-skew-psec = <1400>;
> > +               rxdv-skew-psec = <0>;
> > +               txdv-skew-psec = <0>;
> 
> txen-skew-psec?

OK, will fix this in V3.

Thanks,
Biju