Re: [PATCH 2/3] arm64: dts: qcom: Add the Lenovo IdeaCentre Mini X

[Konrad Dybcio]

On 3/25/26 11:34 PM, Bjorn Andersson wrote:
> The Lenovo IdeaCentre Mini X (Snapdragon) Desktop is a Hamoa-based
> ultracompact desktop PC. It provides HDMI, DisplayPort, USB Type-C
> display outputs, 5 additional USB ports, Ethernet, dual NVME slots,
> headphone jack, WiFi, and Bluetooth.
> 
> Introduce a DeviceTree describing this device.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxxxx>
> ---

[...]

> +&iris {
> +	firmware-name = "qcom/x1e80100/LENOVO/91B6/qcvss8380.mbn";
> +	status = "okay";

nit: \n before status, please

[...]

> +&usb_1_ss1_qmpphy {
> +	vdda-phy-supply = <&vreg_l2j>;
> +	vdda-pll-supply = <&vreg_l2d>;
> +
> +	/delete-property/ mode-switch;
> +	/delete-property/ orientation-switch;
> +
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			/delete-node/ endpoint;
> +
> +			/* XXX: why @0? */

Because the binding defined it that way

Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml

->

ports:
  port@0:
    endpoint@0:
	Display Port Output lanes of the PHY when used with static mapping [...]


> +			usb_1_ss1_qmpphy_out_dp: endpoint@0 {
> +				reg = <0>;
> +
> +				data-lanes = <3 2 1 0>;
> +				remote-endpoint = <&dp_port_in>;
> +			};
> +		};
> +	};
> +};
> +
> +&usb_1_ss2_qmpphy {
> +	vdda-phy-supply = <&vreg_l2j>;
> +	vdda-pll-supply = <&vreg_l2d>;
> +
> +	/delete-property/ mode-switch;
> +	/delete-property/ orientation-switch;
> +
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			/delete-node/ endpoint;
> +
> +			/* XXX: why @0? */

Same here

other than that, please fix up the odd misordered pinctrl-n/pinctrl-names
and feel free to add my:

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad