Re: [PATCH v3 05/12] amd-pstate: Add support for CPPC_REQ2 and FLOOR_PERF

[Gautham R. Shenoy]

Hello Mario,

On Tue, Mar 24, 2026 at 04:38:07PM -0500, Mario Limonciello wrote:
> 
> 

[..snip..]

> > index cb45fdca27a6..f04561da4518 100644
> > --- a/drivers/cpufreq/amd-pstate.h
> > +++ b/drivers/cpufreq/amd-pstate.h
> > @@ -62,9 +62,12 @@ struct amd_aperf_mperf {
> >    * @cpu: CPU number
> >    * @req: constraint request to apply
> >    * @cppc_req_cached: cached performance request hints
> > + * @cppc_req2_cached: cached value of MSR_AMD_CPPC_REQ2
> >    * @perf: cached performance-related data
> >    * @prefcore_ranking: the preferred core ranking, the higher value indicates a higher
> >    * 		  priority.
> > + * @floor_perf_cnt: Cached value of the number of distinct floor
> > + *                  performance levels supported
> >    * @min_limit_freq: Cached value of policy->min (in khz)
> >    * @max_limit_freq: Cached value of policy->max (in khz)
> >    * @nominal_freq: the frequency (in khz) that mapped to nominal_perf
> > @@ -87,10 +90,13 @@ struct amd_cpudata {
> >   	struct	freq_qos_request req[2];
> >   	u64	cppc_req_cached;
> > +	u64	cppc_req2_cached;
> >   	union perf_cached perf;
> >   	u8	prefcore_ranking;
> > +	u8	floor_perf_cnt;
> > +	u8	bios_floor_perf;
> 
> It looks like you forgot to update doc for bios_floor_perf

Thanks for catching this. I will add the doc for bios_floor_perf in v4.


-- 
Thanks and Regards
gautham.