Re: [PATCH v2 09/12] arm64: dts: imx8mp-sr-som: Correct PAD settings for PMIC_nINT
From: Josua Mayer
Date: Thu Mar 26 2026 - 08:42:27 EST
Hi Peng,
Am 26.03.26 um 10:55 schrieb Peng Fan:
>> Subject: Re: [PATCH v2 09/12] arm64: dts: imx8mp-sr-som: Correct
>> PAD settings for PMIC_nINT
>>> --- a/arch/arm64/boot/dts/freescale/imx8mp-sr-som.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-sr-som.dtsi
>>> @@ -174,7 +174,7 @@ pmic: pmic@25 {
>>> pinctrl-0 = <&pmic_pins>;
>>> pinctrl-names = "default";
>>> interrupt-parent = <&gpio1>;
>>> - interrupts = <3 GPIO_ACTIVE_LOW>;
>>> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>> This is a good change, but it should be mentioned in the commit
>> message, or split to a separate patch. Same for other patches in this
>> series where you make the same change.
> Thanks, waiting to see if any board owners would give a test.
> Then I will update in V3.
>
> Thanks,
> Peng.
Looks correct to me.
Reviewed-by: Josua Mayer <josua@xxxxxxxxxxxxx>