RE: [PATCH net-next v4 1/3] r8152: fix incorrect register write to USB_UPHY_XTAL

[Hayes Wang]

Chih Kai Hsu <hsu.chih.kai@xxxxxxxxxxx>
> Sent: Thursday, March 26, 2026 3:39 PM
> To: kuba@xxxxxxxxxx; davem@xxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; nic_swsd <nic_swsd@xxxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; bjorn@xxxxxxx; pabeni@xxxxxxxxxx; Chih Kai Hsu
> <hsu.chih.kai@xxxxxxxxxxx>
> Subject: [PATCH net-next v4 1/3] r8152: fix incorrect register write to
> USB_UPHY_XTAL
> 
> The old code used ocp_write_byte() to clear the OOBS_POLLING bit
> (BIT(8)) in the USB_UPHY_XTAL register, but this doesn't correctly clear a bit in
> the upper byte of the 16-bit register.
> 
> Fix this by using ocp_write_word() instead.
> 
> Fixes: 195aae321c82 ("r8152: support new chips")
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@xxxxxxxxxxx>

Reviewed-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

Best Regards,
Hayes