RE: [PATCH net-next v4 2/3] r8152: add helper functions for PLA/USB OCP registers

[Hayes Wang]

Chih Kai Hsu <hsu.chih.kai@xxxxxxxxxxx>
> Sent: Thursday, March 26, 2026 3:39 PM
> To: kuba@xxxxxxxxxx; davem@xxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; nic_swsd <nic_swsd@xxxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; bjorn@xxxxxxx; pabeni@xxxxxxxxxx; Chih Kai Hsu
> <hsu.chih.kai@xxxxxxxxxxx>
> Subject: [PATCH net-next v4 2/3] r8152: add helper functions for PLA/USB OCP
> registers
> 
> Add the following bitwise operation functions for PLA/USB OCP registers
> to simplify the code.
> 
> - ocp_dword_w0w1()
> - ocp_word_w0w1()
> - ocp_byte_w0w1()
> - ocp_dword_clr_bits()
> - ocp_dword_set_bits()
> - ocp_word_clr_bits()
> - ocp_word_set_bits()
> - ocp_word_test_and_clr_bits()
> - ocp_byte_clr_bits()
> - ocp_byte_set_bits()
> 
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@xxxxxxxxxxx>

Reviewed-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

Best Regards,
Hayes