RE: [PATCH net-next v4 3/3] r8152: add helper functions for PHY OCP registers

[Hayes Wang]

Chih Kai Hsu <hsu.chih.kai@xxxxxxxxxxx>
> Sent: Thursday, March 26, 2026 3:39 PM
> To: kuba@xxxxxxxxxx; davem@xxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; nic_swsd <nic_swsd@xxxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; bjorn@xxxxxxx; pabeni@xxxxxxxxxx; Chih Kai Hsu
> <hsu.chih.kai@xxxxxxxxxxx>
> Subject: [PATCH net-next v4 3/3] r8152: add helper functions for PHY OCP
> registers
> 
> Add the following bitwise operation functions for PHY OCP registers to simplify
> the code.
> 
> - ocp_reg_w0w1()
> - ocp_reg_clr_bits()
> - ocp_reg_set_bits()
> - sram_write_w0w1()
> - sram_clr_bits()
> - sram_set_bits()
> - r8152_mdio_clr_bit()
> - r8152_mdio_set_bit()
> - r8152_mdio_test_and_clr_bit()
> 
> In addition, remove variable set but not used from r8153_init(),
> r8153b_init() and r8153c_init().
> 
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@xxxxxxxxxxx>

Reviewed-by: Hayes Wang <hayeswang@xxxxxxxxxxx>

Best Regards,
Hayes