Re: [PATCH net-next v5] net: pppoe: implement GRO/GSO support
From: Xin Long
Date: Thu Mar 26 2026 - 10:50:34 EST
On Wed, Mar 25, 2026 at 10:43 PM Qingfang Deng <dqfext@xxxxxxxxx> wrote:
>
> Hi all,
>
> In some cases (such as BIG TCP) a GRO skb length can overflow a u16,
> then what should I do with the u16 length field here?
I think you can either add a check in pppoe_gro_complete() to ensure
the aggregated size does not exceed U16_MAX, avoiding BIG TCP
behavior; Or, set phdr->length to 0 and rely on skb->len to determine
the actual length, as done in BIG TCP itself.