Re: [PATCH 2/2] media: i2c: ov5645: Convert to CCI register access helpers

[Lad, Prabhakar]

Hi Xiaolei,

On Thu, Mar 26, 2026 at 3:00 PM xiaolei wang <xiaolei.wang@xxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On 3/26/26 22:21, Prabhakar wrote:
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and know the content is safe.
> >
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Convert the ov5645 driver to use the V4L2 CCI register access helpers
> > and regmap infrastructure instead of the custom I2C register access
> > implementation.
> >
> > Keep ov5645_set_register_array() as ov5645_global_init_setting requires
> > a delay between specific register writes, which cannot be expressed
> > through the generic CCI multi-write helper.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> >   drivers/media/i2c/Kconfig  |   1 +
> >   drivers/media/i2c/ov5645.c | 901 ++++++++++++++++++-------------------
> >   2 files changed, 429 insertions(+), 473 deletions(-)
> >
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > index 20482be35f26..921186d36589 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -526,6 +526,7 @@ config VIDEO_OV5640
> >          tristate "OmniVision OV5640 sensor support"
> >          depends on OF
> >          depends on GPIOLIB
> > +       select V4L2_CCI_I2C
>
> The V4L2_CCI_I2C select option seems to have been placed here on the OV5640.
>
Ouch my bad, I will fix that in v2.

Cheeers,
Prabhakar