Re: [PATCH] cachefiles: Fix excess dput() after end_removing()

From: David Howells

Date: Thu Mar 26 2026 - 12:12:35 EST


NeilBrown <neilb@xxxxxxxxxxx> wrote:

> - ret = cachefiles_bury_object(cache, NULL, dir, victim,
> + ret = cachefiles_bury_object(cache, NULL, dir, dget(victim),

I would prefer the dget() to be on a line on its own before this one to make
it easier to spot.

> If you agree I can post a properly formated patch which explanation.

That would be great!

Thanks,
David