Re: [PATCH] docs: kernel-parameters: fix architecture alignment for pt, nopt, and nobypass

[Randy Dunlap]

Hi,

On 3/26/26 12:46 AM, lirongqing wrote:
> From: Li RongQing <lirongqing@xxxxxxxxx>
> 
> Commit ab0e7f20768a ("Documentation: Merge x86-specific boot options doc
> into kernel-parameters.txt") introduced a formatting regression where
> architecture tags were placed on separate lines with broken indentation.
> This caused the 'nopt' [X86] parameter to appear as if it belonged to
> the [PPC/POWERNV] section.
> 
> Fix the formatting by placing the architecture tags on the same line as
> their respective parameters ('pt', 'nopt', and 'nobypass') and restoring
> proper indentation.
> 
> Fixes: ab0e7f20768a ("Documentation: Merge x86-specific boot options doc into kernel-parameters.txt")
> Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 03a5506..dc1c5bd 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2615,12 +2615,9 @@ Kernel parameters
>  			Intel machines). This can be used to prevent the usage
>  			of an available hardware IOMMU.
>  
> -			[X86]
> -		pt
> -			[X86]
> -		nopt
> -			[PPC/POWERNV]
> -		nobypass
> +		pt  	[X86]
> +		nopt	[X86]
> +		nobypass	[PPC/POWERNV]
>  			Disable IOMMU bypass, using IOMMU for PCI devices.
>  
>  		[X86]

This looks good as far as it goes, but there are still some problems IMO.

These are all iommu= options, but iommu says that it's for [X86,EARLY].
No PPC/POWERNV mentioned there.

Then immediately following nobypass, there is this:
		[X86]
		AMD Gart HW IOMMU-specific options:

which is also in questionable format. The [X86] isn't needed at all IMO,
or if it's desirable, those 2 lines should be on one line.

Anyway, for this patch:
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

-- 
~Randy