Re: [PATCH net-next 1/3] dpll: add actual frequency monitoring to netlink spec
From: Ivan Vecera
Date: Thu Mar 26 2026 - 13:42:18 EST
On 3/26/26 12:06 PM, Vadim Fedorenko wrote:
On 25/03/2026 19:39, Ivan Vecera wrote:MEASURED looks good... will change this appropriately.
Add DPLL_A_FREQUENCY_MONITOR device attribute to allow control over
the frequency monitor feature. The attribute uses the existing
dpll_feature_state enum (enable/disable) and is present in both
device-get reply and device-set request.
Add DPLL_A_PIN_ACTUAL_FREQUENCY pin attribute to expose the measured
input frequency in Hz. The attribute is present in the pin-get reply.
Overall looks ok, but the wording can be improved, I think. What about
using "MEASURED" or "READ" instead of "ACTUAL"? The spec file has this
note already, looks like there were some concerns already?
Thanks,
Ivan