Re: [PATCH v2 09/13] selftests/mm: skip uffd-wp-mremap if UFFD write-protect is unsupported

From: Andrew Morton

Date: Thu Mar 26 2026 - 14:50:52 EST


On Thu, 26 Mar 2026 23:31:10 +0530 Sayali Patil <sayalip@xxxxxxxxxxxxx> wrote:

> > pagesize = getpagesize();
> > nr_thpsizes = detect_thp_sizes(thpsizes, ARRAY_SIZE(thpsizes));
> > _
> >
> Hi Andrew,
> I have some updates to [PATCH v2 04/13] selftests/mm: fix cgroup task
> placement and tolerance in hugetlb_reparenting_test.sh, as Venkat
> reported failures with the current version.
>
> Should I send a v3 of the full series, or just a fixup patch for
> hugetlb_reparenting_test.sh?

A full resend is fine, thanks. I'll prepare a diff showing all the
changes since v2 for you to double-check and for people who already
reviewed v2.

> Also, if you prefer a v3, should I include
> above fix for
> selftests-mm-skip-uffd-wp-mremap-if-uffd-write-protect-is-unsupported as
> well?

Yes please, integrate all fixups.

You may choose to track those fixups the way I do:

[avagin@xxxxxxxxxx: fix lock leak in mfill_get_vma()]
Link: https://lkml.kernel.org/r/20260316173829.1126728-1-avagin@xxxxxxxxxx
[akpm@xxxxxxxxxxxxxxxxxxxx: update mfill_copy_folio_retry()]
Link: https://lkml.kernel.org/r/20260316173829.1126728-1-avagin@xxxxxxxxxx
Link: https://lkml.kernel.org/r/20260306171815.3160826-6-rppt@xxxxxxxxxx
Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
Signed-off-by: Andrei Vagin <avagin@xxxxxxxxxx>
Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx>
Cc: Axel Rasmussen <axelrasmussen@xxxxxxxxxx>
...

Other people also do this sometimes, usually not.