Re: [PATCH v11 2/4] crypto: spacc - Add SPAcc ahash support
From: Herbert Xu
Date: Fri Mar 27 2026 - 05:21:10 EST
On Wed, Mar 18, 2026 at 12:48:06PM +0530, Pavitrakumar Managutte wrote:
>
> + switch (salg->mode->id) {
> + case CRYPTO_MODE_HMAC_SHA224:
> + rc = do_shash(salg->dev, "sha224", tctx->ipad, key,
> + keylen);
> + break;
Since you're doing a giant switch statement anyway, please convert
this to use lib/crypto instead of shash.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt