Re: [PATCH v10 1/7] dt-bindings: media: qcom,x1e80100-camss: Add simple-mfd compatible

[Konrad Dybcio]

On 3/17/26 5:21 PM, Bryan O'Donoghue wrote:
> On 17/03/2026 16:00, Krzysztof Kozlowski wrote:
>>>> I actually got the idea from:
>>>>
>>>> commit fe6a952b567f6a771d087d2e969914f31574d6ab
>>>> Author: Krzysztof Kozlowski<krzk@xxxxxxxxxx>
>>>> Date:   Fri Jan 27 20:40:50 2023 +0100
>>> If you refer to my commits, at least read them. Do you see children
>>> there? Yes. You have none.
>>>
>>> Plus trying to get 13 year old legacy device without dtbs_check warnings
>>> is different thing than correcting a recently introduced bindings.
>>> Terrible example to take... And if you find example from 20 years ago,
>>> it will be even worse.
>>>
>> One more thing, that commit was still correct because it fulfilled the
>> simple-mfd requirement of lack of dependency on the parent. I do not
>> believe your code fulfills it. I am pretty sure it does not.
> 
> Yeah I take the logic of that point:
> 
> CSIPHY here depends on the GDSC, power-domains and clocks we've listed, its not being supplied by any of the other blocks that live inside of the rest.
> 
> They don't require any resources from the parent and the parent consumes the child phys via phandles.
> 
> To my mind that fits the criteria you've set of !depends on parent.

FWIW the problem here seems to be the assumption that:

"needs to probe child devices" == "must have simple-mfd compatible"

You can just add a devm_of_platform_populate() somewhere in CAMSS probe
(or do component_device like in drm/msm)

Konrad