Re: [PATCH 2/3] arm64: dts: qcom: Add the Lenovo IdeaCentre Mini X

[Luca Weiss]

Hi Bjorn,

On Wed Mar 25, 2026 at 11:34 PM CET, Bjorn Andersson wrote:
> The Lenovo IdeaCentre Mini X (Snapdragon) Desktop is a Hamoa-based
> ultracompact desktop PC. It provides HDMI, DisplayPort, USB Type-C
> display outputs, 5 additional USB ports, Ethernet, dual NVME slots,
> headphone jack, WiFi, and Bluetooth.
>
> Introduce a DeviceTree describing this device.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/Makefile                  |    1 +
>  .../qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts  | 1199 ++++++++++++++++++++
>  2 files changed, 1200 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index d69e5f3132c4fd3fbf1ac90e83adf6af6b104a93..fbbec696ac161af42c18acc344a228ba461f65a7 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -21,6 +21,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk.dtb
>  hamoa-iot-evk-el2-dtbs	:= hamoa-iot-evk.dtb x1-el2.dtbo
>  
>  dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk-el2.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-lenovo-ideacentre-mini-01q8x10.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-rdp432-c2.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-tplink-archer-ax55-v1.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp441.dtb
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts
> new file mode 100644
> index 0000000000000000000000000000000000000000..cc90cb58a9c17ad166dd641d9bbc03b7df5686a6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts
> @@ -0,0 +1,1199 @@

<snip>

> +&remoteproc_cdsp {
> +	firmware-name = "qcom/x1e80100/LENOVO/91B6/qccdsp8380.mbn",
> +			"qcom/x1e80100/LENOVO/91B6/cdsp_dtbs.elf";
> +
> +	status = "okay";
> +};
> +
> +&smb2360_0 {
> +	status = "okay";
> +};
> +
> +&smb2360_0 {
> +	status = "okay";
> +};

You have this smb2360_0 node enabled twice.

I checked this AI review thingy to see what it's saying , and while most
suggestions are probably kinda useless, it did spot that bit, which I
thought you may want to fix in v2.

https://sashiko.dev/#/patchset/20260325-ideacentre-v1-0-768b66aaef30%40oss.qualcomm.com?patch=10329
> This isn't a bug, but the smb2360_0 node is defined twice. Can the duplicate
> be removed?

Regards
Luca