Re: [PATCH v2 0/4] ARM: tegra: lg-x3: add missing nodes

[Svyatoslav Ryhel]

27 березня 2026 р. 17:05:34 GMT+02:00, Thierry Reding <thierry.reding@xxxxxxxxxx> пише:
>On Mon, Jan 26, 2026 at 12:10:14PM +0200, Svyatoslav Ryhel wrote:
>> With the recent kernel updates, Tegra30-based LG smartphones now support
>> several additional features, including an RGB-DSI bridge, DSI panels,
>> MUIC, a charger, a battery temperature sensor, OTG mode, and capacitive
>> buttons on the P895. Add required nodes to device trees.
>> 
>> ---
>> Changes in v2:
>> - fixed dw9714 and tx13d100vm0eaa nodes
>> - added video device pipes graph
>> 
>> Regarding CHECK_DTBS output in v2:
>> - nvidia,tegra30-pcie, nvidia,tegra30-gmi, nvidia,tegra30-kbc,
>>   nvidia,tegra20-kbc, nvidia,tegra30-ahub are not documented yet
>> - nvidia,tegra30-vi was adjusted and applied, change did not apper yet
>>   (https://lore.kernel.org/lkml/176860988748.1688420.11717122647073678.b4-ty@xxxxxxxxxx/)
>> - st,m24c08 appers undocumented though it seems to be different from
>>   st,24c08, at least they google as separate devices. atmel,24c08 is not
>>   documented, though it is widey used in linux device trees and is
>>   supported by driver. Here is one of examples:
>>   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/boot/dts/allwinner/sun7i-a20-linutronix-testbox-v2.dts?h=next-20260123#n33
>> - onnn,mt9m114 does not have 'orientation' property, though it should
>>   include it since it is generic for camera devices
>> - ti,lp8720 and maxim,max77663 have txt documentation and are not yet
>>   converted to DT schema
>> - backlight in panel nodes was not added since lm3533 has no DT support
>> - missing '#io-channel-cells' in ti,tsc2007 addressed in
>>   https://lore.kernel.org/lkml/20260122193549.29858-2-clamor95@xxxxxxxxx/
>> - missing dsi controller properties of ssd2825 addressed in
>>   https://lore.kernel.org/lkml/20260123073411.7736-2-clamor95@xxxxxxxxx/
>> - missing '#io-channel-cells' in generic-adc-thermal was proposed in but rejected
>>   https://lore.kernel.org/lkml/20250310075638.6979-2-clamor95@xxxxxxxxx/
>> ---
>> 
>> Svyatoslav Ryhel (4):
>>   ARM: tegra: lg-x3: add panel and bridge nodes
>>   ARM: tegra: lg-x3: add USB and power related nodes
>>   ARM: tegra: lg-x3: add node for capacitive buttons
>>   ARM: tegra: lg-x3: complete video device graph
>> 
>>  arch/arm/boot/dts/nvidia/tegra30-lg-p880.dts |  39 +++
>>  arch/arm/boot/dts/nvidia/tegra30-lg-p895.dts |  79 +++++
>>  arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi  | 328 ++++++++++++++++++-
>>  3 files changed, 429 insertions(+), 17 deletions(-)
>
>Patches 1-3 applied. Patch 4 has checkpatch has checkpatch warnings:
>
>	WARNING: DT compatible string "st,m24c08" appears un-documented -- check ./Documentation/devicetree/bindings/
>	#255: FILE: arch/arm/boot/dts/nvidia/tegra30-lg-x3.dtsi:1243:
>	+			compatible = "st,m24c08", "atmel,24c08";
>
>So I've left it out for now.
>

st,m24c08 appers undocumented though it seems to be different from
st,24c08 (in schema) at least they google as separate devices. atmel,24c08 is not
documented, though it is widey used in linux device trees and is
supported by driver. Here is one of examples:
  https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm/boot/dts/allwinner/sun7i-a20-linutronix-testbox-v2.dts?h=next-20260123#n33

I assume patch 4 should be fine and most likely schema needs to be adjusted to cover this compatible (since it exists and is used).

>Thierry