Re: [PATCH v1] drm/panel-edp: Add 2 panels used by MT8186 Chromebooks

[Doug Anderson]

Hi,

On Mon, Mar 23, 2026 at 11:14 PM Terry Hsiao
<terry_hsiao@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> The raw EDIDs for each panel:
>
> CSW
> - PNB601LS1-2
> 00 ff ff ff ff ff ff 00 0e 77 0a 11 00 00 00 00
> 30 23 01 04 a5 1a 0e 78 03 a1 35 9b 5e 58 91 25
> 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 09 1e 56 dc 50 00 28 30 30 20
> 36 00 00 90 10 00 00 1a 06 14 56 dc 50 00 28 30
> 30 20 36 00 00 90 10 00 00 1a 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02
> 00 0c 3d ff 0c 3c 7d 0e 0b 17 7d 00 00 00 00 e8
>
> LGD
> - LP116WHA-SPB1
> 00 ff ff ff ff ff ff 00 30 e4 fe 07 01 01 00 00
> 00 24 01 04 a5 1a 0e 78 03 72 e5 9c 5e 5b 94 27
> 19 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 d5 21 56 a0 50 00 b2 30 30 20
> f8 0c 00 90 10 00 00 1a 8e 16 56 a0 50 00 b2 30
> 30 20 f8 0c 00 90 10 00 00 1a 00 00 00 fd 00 28
> 3c 39 39 09 01 0a 20 20 20 20 20 20 00 00 00 02
> 00 0f 3d ff 0f 3c 7d 0d 0a 15 7d 00 00 00 01 da
>
> 70 20 79 02 00 25 00 09 57 52 01 57 52 01 28 3c
> 80 81 00 15 74 1a 00 00 03 01 28 3c 00 00 4a 5a
> 4a 5a 3c 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ef 90
>
> Signed-off-by: Terry Hsiao <terry_hsiao@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)

The ${SUBJECT} of your patch is too generic. There are far too many
patches saying "add N panels for <some> Chromebook". Please choose
more descriptive subjects.

In this case, I've fixed it for you to:

drm/panel-edp: Add CSW PNB601LS1-2 and LGD LP116WHA-SPB1

Patches typically get applied more quickly if I don't need to do
manual fixups like this.


> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 497dcd48f57b..7d80524a9406 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -2072,6 +2072,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('C', 'S', 'W', 0x1100, &delay_200_500_e80_d50, "MNB601LS1-1"),
>         EDP_PANEL_ENTRY('C', 'S', 'W', 0x1103, &delay_200_500_e80_d50, "MNB601LS1-3"),
>         EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50_d100, "MNB601LS1-4"),
> +       EDP_PANEL_ENTRY('C', 'S', 'W', 0x110A, &delay_200_500_e50, "PNB601LS1-2"),

Convention in the Linux kernel (and, more importantly, in this file)
is lowercase hex. I've changed the above 0x110A to 0x110a.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Pushed to drm-misc-next.

[1/1] drm/panel-edp: Add CSW PNB601LS1-2 and LGD LP116WHA-SPB1
      commit: e88b5cc6d6e5b1ba257f00e5c186ba137e6e8bc3