Re: [PATCH v3 0/3] ASoC: Intel: Fix MCLK leaks in platform_clock_control

From: Mark Brown

Date: Fri Mar 27 2026 - 17:12:39 EST


On Fri, Mar 27, 2026 at 05:04:05PM -0400, aravindanilraj0702@xxxxxxxxx wrote:
> From: Aravind Anilraj <aravindanilraj0702@xxxxxxxxx>
>
> In three Intel ASoC board drivers, the EVENT_ON path in
> platform_clock_control() enables MCLK using clk_prepare_enable(), but
> error paths fail to call clk_disable_unprepare(), leaking a clock
> reference.

Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed. Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing. If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

Attachment: signature.asc
Description: PGP signature