Re: [PATCH v5 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver

From: Bryan O'Donoghue

Date: Fri Mar 27 2026 - 18:13:37 EST


On 27/03/2026 20:54, Dmitry Baryshkov wrote:
I think, I've left similar feedback already. Please rework a single
structure-less table into generic and per-lane configuration. It doesn't
make sense to repeat the same configuration N times, just with the
different offset.

If you remember you also said that was fine for a follow-on series after merging, and you asked for a commit log to that effect.

i.e.

"The register init sequence table is imported verbatim from the existing
CAMSS csiphy driver. A follow-up series will rework the table to extract
the repetitive per-lane pattern into a loop."

---
bod