Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node

From: Thierry Reding

Date: Fri Mar 27 2026 - 19:48:59 EST


On Fri, Mar 27, 2026 at 05:28:04PM +0200, Svyatoslav Ryhel wrote:
>
>
> 27 березня 2026 р. 17:18:42 GMT+02:00, Thierry Reding <thierry.reding@xxxxxxxxxx> пише:
> >On Mon, Feb 23, 2026 at 08:55:00AM +0200, Svyatoslav Ryhel wrote:
> >> All ASUS Transformers have micro-HDMI connector directly available. After
> >> Tegra HDMI got bridge/connector support, we should use connector framework
> >> for proper HW description.
> >>
> >> Tested-by: Andreas Westman Dorcsak <hedmoo@xxxxxxxxx> # ASUS TF T30
> >> Tested-by: Robert Eckelmann <longnoserob@xxxxxxxxx> # ASUS TF101 T20
> >> Tested-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx> # ASUS TF201 T30
> >> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> >> ---
> >> .../boot/dts/nvidia/tegra30-asus-tf600t.dts | 21 +++++++++++++++++--
> >> 1 file changed, 19 insertions(+), 2 deletions(-)
> >
> >Two things about you commit messages that I have to fixup every time:
> >
> > 1. caps after the subject prefix
>
> Prefix ends with ':' which does not imply using of capital letter as '.' '!' or '?' do. Linux documentation does not regulate this.
>
> Even more, examples use lower case
>
> [PATCH 001/123] subsystem: summary phrase

I don't care.

> > 2. wrap commit message at 72 characters
> >
>
> The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch.
>
> The commit message is wrapped by 75 characters, as linux documentation requests.

Fine, I'll accept 75 columns then. Pay attention to point 1 though.
Helps keep me in a good mood.

Thierry

Attachment: signature.asc
Description: PGP signature