Re: [PATCH v1 3/5] dt-bindings: memory: Add Tegra114 memory client IDs

From: Krzysztof Kozlowski

Date: Sat Mar 28 2026 - 08:11:46 EST


On 28/03/2026 12:40, Krzysztof Kozlowski wrote:
> On 28/03/2026 00:53, Thierry Reding wrote:
>> On Tue, Feb 17, 2026 at 08:22:24AM +0100, Krzysztof Kozlowski wrote:
>>> On 26/01/2026 20:07, Svyatoslav Ryhel wrote:
>>>> Each memory client has unique hardware ID, add these IDs.
>>>>
>>>> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
>>>> Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
>>>> Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
>>>> ---
>>>> include/dt-bindings/memory/tegra114-mc.h | 67 ++++++++++++++++++++++++
>>>
>>> This is never a separate commit. Squash with the binding.
>>
>> You have previously requested that bindings and driver changes be
>> applied together. If this header file is applied to your memory tree it
>> means I cannot apply the corresponding DT changes until a release later
>> because the defines are part of the header included in the DT bindings
>> patch.
>
> I cannot apply the driver either without it, because it uses it, no?
> Otherwise what is it doing in bindings if the driver is not using it?
>
>>
>> Seems a bit suboptimal. Do you have any good ideas on how to solve that
>
> We listed five already in maintainer soc profile. Are they not good?
>
>> particular issue? The only one that comes to mind is for you to pick up
>> the DT changes as well, though that obviously runs a greater risk of
>> causing merge conflicts down the road.

One more thing:
There is no DTS here and nothing explains (commit msgs, changelogs or
cover letter) that there is any dependency and this was supposed to go
other tree. So the squash-or-not-squash is absolutely irrelevant to your
question/problem how DTS should deal with it.

Best regards,
Krzysztof