Re: [PATCH] ALSA: hda: intel: Drop obsolete probe-work unlock workaround

[Takashi Iwai]

On Sun, 29 Mar 2026 00:42:01 +0100,
Cássio Gabriel wrote:
> 
> Commit ab949d519601 ("ALSA: hda - Fix deadlock of controller device
> lock at unbinding") added a temporary device_unlock()/device_lock()
> pair around probe-work cancellation to avoid a deadlock between
> controller unbind and codec probe.
> 
> That deadlock depended on the driver core taking both a device lock and
> its parent lock during bind and unbind. Since commit 8c97a46af04b
> ("driver core: hold dev's parent lock when needed") and follow-up
> fixes, the parent lock is only taken when bus->need_parent_lock is set.
> The HDA bus does not set that flag, so codec binding no longer locks
> the controller device as the codec's parent.
> 
> Keep cancel_delayed_work_sync(), since the async probe/remove race
> still needs to be serialized, but drop the stale unlock/relock
> workaround and its outdated FIXME comment. Keeping it around only
> opens an unnecessary unlocked window inside azx_remove().
> 
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@xxxxxxxxx>

A good catch.  Applied to for-next branch now.


thanks,

Takashi